Skip to content

Support matrix trimming in pipeline - #1459

Merged
mthalman merged 2 commits into
dotnet:mainfrom
mthalman:issue1417-matrix-trimming-pipeline
Oct 9, 2024
Merged

mthalman merged 2 commits into
dotnet:mainfrom
mthalman:issue1417-matrix-trimming-pipeline

Conversation

@mthalman

@mthalman mthalman commented Oct 4, 2024

Copy link
Copy Markdown
Member

Contributes to #1417

This updates the pipeline infra to make use of the new matrix trimming logic from #1449.

Matrix generation now requires some of the same variables as the build because they now both need to access the image info file from the versions repo. So a lot of the changes here are to refactor the templates so that both the build and "generate matrix" jobs can share the same logic for computing variables.

The trimming behavior is opt in by setting a trimCachedImagesForMatrix variable. Trimming is explicitly not enabled for the test stage.

Due to some weird behavior from AzDO, I had to refactor how the repos get cloned in these two stages. For whatever reason, it wasn't allowing me access the repo name from a parameter within the job template. So that's been factored out into a parameter that gets passed in from the stage template.

@mthalman
mthalman requested a review from a team as a code owner October 4, 2024 15:42
@ghost

ghost commented Oct 4, 2024

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged label Oct 4, 2024
@ghost

ghost commented Oct 4, 2024

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants