Repository navigation
Support matrix trimming in pipeline - #1459
Merged
mthalman merged 2 commits intoOct 9, 2024
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lbussell
reviewed
Oct 7, 2024
lbussell
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1417
This updates the pipeline infra to make use of the new matrix trimming logic from #1449.
Matrix generation now requires some of the same variables as the build because they now both need to access the image info file from the versions repo. So a lot of the changes here are to refactor the templates so that both the build and "generate matrix" jobs can share the same logic for computing variables.
The trimming behavior is opt in by setting a
trimCachedImagesForMatrixvariable. Trimming is explicitly not enabled for the test stage.Due to some weird behavior from AzDO, I had to refactor how the repos get cloned in these two stages. For whatever reason, it wasn't allowing me access the repo name from a parameter within the job template. So that's been factored out into a parameter that gets passed in from the stage template.